fix: test untested path in ak.cartesian & broadcasting
#2329
Conversation
|
@jpivarski as this touches broadcasting code, I'd appreciate your eyes to take a close look at the changes to |
Codecov Report
Additional details and impacted files
|
| @@ -160,7 +160,7 @@ def all_same_offsets(backend: ak._backends.Backend, inputs: list) -> bool: | |||
| my_offsets = index_nplike.empty(0, dtype=np.int64) | |||
| else: | |||
| my_offsets = index_nplike.arange( | |||
| 0, x.content.length, x.size, dtype=np.int64 | |||
| 0, x.content.length + 1, x.size, dtype=np.int64 | |||
There was a problem hiding this comment.
We want a range that is inclusive of the endpoints, which is not the case by default.
There was a problem hiding this comment.
We do? Oh, yes—we do! Offsets always have to be one longer than the array itself; that's right. Good catch!
| elif isinstance(x, RegularArray): | ||
| nextinputs.append(x.content[: x.size * x.length]) |
There was a problem hiding this comment.
We test for RegularArray in all_same_offsets, but here we weren't actually pulling out the content.
| @@ -160,7 +160,7 @@ def all_same_offsets(backend: ak._backends.Backend, inputs: list) -> bool: | |||
| my_offsets = index_nplike.empty(0, dtype=np.int64) | |||
| else: | |||
| my_offsets = index_nplike.arange( | |||
| 0, x.content.length, x.size, dtype=np.int64 | |||
| 0, x.content.length + 1, x.size, dtype=np.int64 | |||
There was a problem hiding this comment.
We do? Oh, yes—we do! Offsets always have to be one longer than the array itself; that's right. Good catch!
This PR:
ak.cartesianbroadcast_and_applythat required this patchak.cartesian